Conversation
[Feature] init config
* add chain config with wrapper * add chain client and query tunnel info on chain * add comment * add test * fix client connect logic * fix from comments * fix relayer folder * fix from comments * remove chain type * fix method name * format util test * change variable names * fix json tag * fix variable name * fx type and test * fix comments * rename field * fix field
RogerKSI
requested changes
Oct 23, 2024
RogerKSI
approved these changes
Oct 23, 2024
* save changes * add query * combine getPacket,getSigning and fix return object in cli * [Fix] Band client fix gomod (#6) * fix gomod * fix github action and lint rule * fix github action * fix action * fix action * fix action * fix action * fix action * fix golangci-lint * fix action * fix by comment in pr * handle query client nil case * fix wrong tunnel router addr * type name and arrangement * fix comment * fix leftover tmbytes --------- Co-authored-by: Tanut Lertwarachai <tanutlertwarachai@Tanuts-MacBook-Pro.local> Co-authored-by: Natthakun Kitthaworn <natthakunk0109@gmail.com>
Kissadada
reviewed
Nov 6, 2024
| tunnel.IsActive, | ||
| ) | ||
|
|
||
| targetChain := tunnel.TargetChainID |
Member
There was a problem hiding this comment.
tunnelChainId is chain's name?
Kissadada
reviewed
Nov 6, 2024
|
|
||
| - name: Configure git for private modules | ||
| env: | ||
| TOKEN: ${{ secrets.SHIBA_TOKEN }} |
Kissadada
reviewed
Nov 6, 2024
| - name: Configure git for private modules | ||
| env: | ||
| TOKEN: ${{ secrets.SHIBA_TOKEN }} | ||
| run: git config --global url."https://nkitlabs:${TOKEN}@github.com".insteadOf "https://github.com" |
Member
There was a problem hiding this comment.
next time, better to use band bot account token for this
Member
There was a problem hiding this comment.
bandbot somehow is not working for this case. think can open PR later to remove it after public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: implement features for tunnel offchain relayer.
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)